Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] ONNX docs and tutorial revision #20269

Merged
merged 6 commits into from
May 14, 2021
Merged

[v1.x] ONNX docs and tutorial revision #20269

merged 6 commits into from
May 14, 2021

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented May 13, 2021

No description provided.

@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, windows-gpu, unix-cpu, website, centos-cpu, edge, centos-gpu, unix-gpu, clang, windows-cpu, sanity]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label May 13, 2021
waytrue17
waytrue17 approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@waytrue17 waytrue17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

josephevans
josephevans approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small spelling mistakes, but looks good!

docs/python_docs/python/tutorials/deploy/export/onnx.md Outdated Show resolved Hide resolved
docs/python_docs/python/tutorials/deploy/export/onnx.md Outdated Show resolved Hide resolved
python/mxnet/onnx/README.md Outdated Show resolved Hide resolved
python/mxnet/onnx/README.md Outdated Show resolved Hide resolved
@Zha0q1
Copy link
Contributor Author

Zha0q1 commented May 13, 2021

Just a few small spelling mistakes, but looks good!

Good catches! I guess that's the downside of working in vim lol

@mseth10 mseth10 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels May 14, 2021
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 14, 2021
@Zha0q1 Zha0q1 merged commit 32a3104 into apache:v1.x May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@waytrue17 waytrue17 waytrue17 approved these changes

@josephevans josephevans josephevans approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Zha0q1 @mxnet-bot @josephevans @waytrue17 @mseth10